Switch to allow header timestamps to be UTC #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! will go through it today! |
May save a few ns.
timeZone var isn't accessed if offest is zero
|
Out of interest, what reference did you use to craft the ASM to get the go-id? |
|
I added comment to |
|
After consideration I thin it's no problem for adding the "TimeUTC" field.
|
|
Let me merge it first, thanks. |
|
Another option is change If user give a non-nil value(e.g. Time.UTC), we will call Time.In for the timestamp, and we also need implement a fast path for time.UTC. |
|
@fireflycons please take a look this approach #66 if you have time, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps I'm missing something, but I could not see how to get the header timestamp to be always UTC instead of system local time.
This PR adds a boolean field to
Loggerso that UTC may be enabled, and the logic for this inheader()Additionally fix a typo in
Loggercomments and disable running of syslog tests on Windows.